Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdctl: fix the default config output of shuffle region scheduler #2416

Merged
merged 1 commit into from
May 13, 2020
Merged

pdctl: fix the default config output of shuffle region scheduler #2416

merged 1 commit into from
May 13, 2020

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented May 13, 2020

What problem does this PR solve?

Fix #2356.

What is changed and how it works?

This PR adds default output for shuffle-region-scheduler when using scheduler config subcommand.

Check List

Tests

  • Unit test

Release note

  • Fix the issue that there is no default output when using scheduler config shuffle-region-scheduler in pd-ctl.

@rleungx
fix the default config output of shuffle region scheduler
dfed717 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added this to the v4.0.0-ga milestone May 13, 2020
@codecov-io
Copy link

Codecov Report

Merging #2416 into master will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2416      +/-   ##
==========================================
+ Coverage   76.16%   76.29%   +0.13%     
==========================================
  Files         206      206              
  Lines       22086    22090       +4     
==========================================
+ Hits        16821    16854      +33     
+ Misses       3969     3950      -19     
+ Partials     1296     1286      -10
Impacted Files Coverage Δ
tools/pd-ctl/pdctl/command/scheduler.go 70.58% <100.00%> (+0.29%) ⬆️
server/region_syncer/client.go 74.80% <0.00%> (-4.59%) ⬇️
server/member/leader.go 71.20% <0.00%> (-2.34%) ⬇️
pkg/mock/mockhbstream/mockhbstream.go 89.23% <0.00%> (-1.54%) ⬇️
pkg/btree/btree.go 86.84% <0.00%> (-0.81%) ⬇️
server/handler.go 51.18% <0.00%> (-0.44%) ⬇️
server/schedule/operator_controller.go 80.84% <0.00%> (-0.17%) ⬇️
server/schedulers/adjacent_region.go 76.59% <0.00%> (+1.06%) ⬆️
server/server.go 78.31% <0.00%> (+1.24%) ⬆️
server/tso/tso.go 81.02% <0.00%> (+1.45%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e3d218...dfed717. Read the comment docs.

@nolouch
Copy link
Contributor

nolouch commented May 13, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2020

Your auto merge job has been accepted, waiting for:

  • 2401

@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2020

/run-all-tests

@sre-bot sre-bot merged commit 8d56174 into tikv:master May 13, 2020
@MyonKeminta MyonKeminta modified the milestones: v4.0.0-ga, v4.0.0-rc.2 May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@nolouch nolouch nolouch approved these changes

@disksing disksing Awaiting requested review from disksing

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
v4.0.0-rc.2
Development

Successfully merging this pull request may close these issues.

scheduler config echo is confusing
6 participants
@rleungx @codecov-io @nolouch @sre-bot @lhy1024 @MyonKeminta